fix(ci): download per-sha nightly binary, keep nightly as rolling alias#582
Merged
Conversation
dmtrKovalenko
force-pushed
the
fix/pinned-nightly-download
branch
from
0ec9a78 to
ee162e5
Compare
…lias PR #580 made nightlies publish to a single rolling `nightly` release and set `release_tag` to `nightly` for downloads. A pinned or stale install then resolved to `nightly` and fetched whatever binary HEAD currently pointed at — an ABI mismatch against its own Lua/FFI layer. Restore per-sha download: `release_tag` is the unique `version` again, so each commit's binaries live in their own permanent release. CI still force-moves the `nightly` tag to HEAD for "give me latest" tooling, gated on `is_release` instead of the now-per-sha `release_tag`. `current_release_tag` prefers the per-sha tag over the `nightly` alias when both point at HEAD.
dmtrKovalenko
force-pushed
the
fix/pinned-nightly-download
branch
from
ee162e5 to
cf4d01f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#580 switched nightly downloads to a single rolling
nightlyrelease and setrelease_tag = 'nightly'. Any pinned or stale install resolves tonightlyand downloads whatever binary HEAD currently points at — an ABI mismatch against its own bundled Lua/FFI layer. Breaks version resolution for anyone not on bleeding-edge main.