Skip to content

Conversation

@d-ylee
Copy link
Contributor

@d-ylee d-ylee commented May 13, 2025

Extends dmwm/WMCore#11955

Removes rotatelogs (apache2-utils)
Related to changes made in dmwm/WMCore to use python native log rotation

This is needed after the above PR is merged, since we won't be using rotatelogs and instead be using Python's native log rotation mechanisms

Removes rotatelogs (apache2-utils)
Related to changes made in dmwm/WMCore to use python native log rotation
@amaltaro
Copy link
Contributor

@belforte we are planning to remove the Apache-utils based rotatelogs util from our WM base image.
If I am not wrong, one of the CRAB services is based on this base image, isn't it?

Do you think this change (plus the WMCore relevant change) can cause CRAB issues? Or is it something that you guys can handle by the next stable release? Thanks!

@belforte
Copy link
Member

@aspiringmind-code may I ask you to kindly look at this ? I am not sure that we use rotatelogs anymore.

@belforte
Copy link
Member

I do not find rotatelog in our code base. I suspect it was used in an old script for JobRouter which we deprecated in favor of using static HTC Routing Tables. Feel free Alan.

@amaltaro
Copy link
Contributor

Thank you for checking this, @belforte

@mapellidario
Copy link
Member

I do not find rotatelog in our code base

it was removed by @novicecpp when dropping support for CephFS, initial implementation here [1] . Then the mention to rotatelogs got lost when he switched to using WMCore pypi packages


[1] https://github.com/dmwm/deployment/pull/1240/files

@belforte
Copy link
Member

belforte commented May 21, 2025

😮
@mapellidario for my education, did you simply remember, or is there a trick I could learn to search GH history ?

I was confusing with usage of logrotate in out puppet profiles :-(

@mapellidario
Copy link
Member

I just recently opened [1] and reconstructed the history of CRAB dropping cephfs :)

No technical magic, I just started from the relevant issue in dmwm/CRABServer then opened all the mentioned issues and PRs. it was a manual task, lots of clickling and reading

[1] dmwm/WMCore#12373

@belforte
Copy link
Member

🙇

@amaltaro
Copy link
Contributor

amaltaro commented Aug 1, 2025

@d-ylee I suspect this PR is no longer relevant. If you confirm this, shall we close this out?

@d-ylee
Copy link
Contributor Author

d-ylee commented Aug 1, 2025

I think so? Does this image use rotatelogs? #1627

@amaltaro
Copy link
Contributor

amaltaro commented Aug 2, 2025

Yes, it inherits from the dmwm-base image, which itself installs apache2-utils. I am closing this out then, but please reopen it in case I missed anything. Thank you!

@amaltaro amaltaro closed this Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants