cmsweb/exporters - build a new version

[mapellidario]

we noticed that the latest tag of cmsweb/exporters is a few years old. we should build a new one.

changes

• new version of golang compiler
• new version of debian
• new version of node_exporter
• new version of apache_exporter
• removed scripts that are not used [1]

suggestion

• maybe we need to change the provider of mongodb_exporter since the one that we are using did not receive any update since 2016. however, checking that alternatives are compatible with what we are running at the moment is out of scope for this PR.

fyi: @amaltaro

---

[1]

The following scripts have been removed from all the dockerfiles in docker/exporters/ and are not imported by any other docker image (or so it seems from a few greps)

docker/exporters/install.sh
docker/exporters/probe.sh
docker/exporters/run.sh

[vkuznet]

For this I suggest you open CMSMONIT issue and ask Monitoring group to install and test it with existing dashboard. If it is compatible then we can easily switch otherwise we need a new dashboard which will use this exporter metrics.

[mapellidario]

i see, but since we are not using mongodb_expoerter in our wmcore images, can we merge this PR, build a new exporter image and tag it with -stable, use it for #1611 , then build a new tag with the new percona/mongodb_exporter after cmsmonit team finish their investigations?

[vkuznet]

yes we can since you dont' change version of mongodb exporter anyway. But please be aware that exporters are used across all services and if you claim we (WM) group not using particular exporter it does not mean it is not in use. The mongodb exporter is used by DAS, and since DAS can be treated as stand-alone entity or part of WM, we (broader scope) is using it :)

[vkuznet]

as I suggested please open up new CMSMON ticket and link it here for cross references, then we can proceed with merge and stable images.

[mapellidario]

I opened the ticket [1] and added it to the comments in the dockerfile.

if you claim we (WM) group not using particular exporter it does not mean it is not in use.

I know, and this is why i proposed a change instead of just removing removing or changing it :)

[1] https://its.cern.ch/jira/projects/CMSMONIT/issues/CMSMONIT-650?filter=allissues

[vkuznet]

@mapellidario , one additional comment I want to clarify with you. You deleted few scripts and I want you to double check that they are no longer in use anywhere. Please add this to the description of the issue that we can refer to this change if necessary. These scripts I used/developed while we port CMSWEB services from RPM based deployment to k8s but it would be useful to grep and see if they are no longer in use. Thanks.

[mapellidario]

I removed the scripts because they have been commented out from the dockerfile (probe.sh and run.sh) [1] or are not present anymore (install.sh) , so they can not be copied from this docker image with COPY --from=.

The only way to use them is to use docker build from a wider context, let's say from ./docker instead of ./docker/exporters, or some other convoluted cp. I scanned this repo with a few greps and couldnt find anything.

I am in favor of cleanups even if i understand that it can be risky. if you prefer, i can restore those files

---

[1]

CMSKubernetes/docker/exporters/Dockerfile

Lines 47 to 48 in 3c5a1e0

	# ADD run.sh /data/run.sh
	# ADD probe.sh /data/probe.sh

[vkuznet]

thank you Dario for cross-checking, I'm ok with deleting those scripts I just want to have a references to easily find them if we'll need them to recover something. That's why I suggested to include explicitly what we delete in a description of this PR.

[mapellidario]

I updated the PR description

[vkuznet]

thank you Dario, changes look good to me.