This repository was archived by the owner on Nov 10, 2022. It is now read-only.
Fixed AmazonS3->files() implementation #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmyers
added a commit
that referenced
this pull request
Aug 5, 2014
Fixed files method in AmazonS3 adapter
Owner
|
Good find! Not sure how that got there, but thanks for fixing it. If you have any other ideas/suggestions/etc let me know, appreciate all your changes so far. |
Contributor
Author
|
Yea, seems like they changed their API somehow... Sure, once I've new ideas/fixes, I'll make a new PR here, it's always a pleasure to contribute back to projects I use. :) Cheers! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if it ever worked before, but currently the implementation is broken: there's no
listKeys()method onS3Clientclass.This PR fixes the implementation to use the high-level
getIterator('ListObjects')iterator, as documented on AWS SDK for PHP here and here.