Add fix for #311 #312
Merged
Add fix for #311 #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is actually the consequences from dn-vm#274. The basic problem is that, before that PR, uninstall didn't properly remove all pieces of the SDK from the manifest. This causes issues with prune because it thinks an SDK is still installed, even though all the pieces on disk have already been removed. The fix is to change the error for this situation into a warning and remove the stale entries from the manifest. Fixes dn-vm#311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is actually the consequences from #274. The basic problem is that, before that PR, uninstall didn't properly remove all pieces of the SDK from the manifest. This causes issues with prune because it thinks an SDK is still installed, even though all the pieces on disk have already been removed. The fix is to change the error for this situation into a warning and remove the stale entries from the manifest.
Fixes #311