Skip to content

Commit ff88149

Browse files
committed
fix: rename typed chevron icons all places to have more consistency
1 parent c490550 commit ff88149

11 files changed

Lines changed: 35 additions & 28 deletions

File tree

packages/dnb-design-system-portal/src/pages/uilib/usage/first-steps/web-components.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ Now we can use our web components right away in our markup.
3333
<!-- prettier-ignore-start -->
3434

3535
```html
36-
<dnb-button icon="chevron-right" text="Custom Element" />
36+
<dnb-button icon="chevron_right" text="Custom Element" />
3737
```
3838

3939
<div class="example-box">
40-
<dnb-button icon="chevron-right" text="Custom Element" />
40+
<dnb-button icon="chevron_right" text="Custom Element" />
4141
</div>
4242

4343
### Input

packages/dnb-design-system-portal/src/shared/menu/Card.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ export default class Card extends PureComponent {
161161
<BottomWrapper>
162162
<Button
163163
variant="tertiary"
164-
icon="chevron-right"
164+
icon="chevron_right"
165165
text="Read more"
166166
tabindex="-1"
167167
/>

packages/dnb-design-system-portal/src/shared/menu/MainMenu.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ export default class MainMenu extends PureComponent {
217217
variant="secondary"
218218
class="main-menu__back dnb-always-focus"
219219
on_click={this.closeMenuHandler}
220-
icon="chevron-left"
220+
icon="chevron_left"
221221
icon_position="left"
222222
text="BACK"
223223
title="Hide Main Menu"

packages/dnb-design-system-portal/src/uilib/components/examples/Button.txt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,35 +22,35 @@
2222
<Button
2323
text="Primary button with icon"
2424
title="This is a button title"
25-
icon="chevron-right"
25+
icon="chevron_right"
2626
/>
2727
<Button
2828
text="Primary button with icon on left"
2929
title="This is a button title"
3030
icon_position="left"
31-
icon="chevron-left"
31+
icon="chevron_left"
3232
/>
3333
<Button
3434
variant="tertiary"
3535
text="Tertiary button with icon on left"
3636
title="This is a button title"
3737
icon_position="left"
38-
icon="chevron-left"
38+
icon="chevron_left"
3939
/>
4040
<Button
4141
variant="tertiary"
4242
text="Tertiary button with icon on left"
4343
title="This is a button title"
4444
icon_position="left"
45-
icon="chevron-left"
45+
icon="chevron_left"
4646
disabled
4747
/>
4848
<Button
4949
text="Primary button with href"
5050
href="?no-cache=1"
5151
title="This is a link"
5252
icon_position="right"
53-
icon="chevron-right"
53+
icon="chevron_right"
5454
/>
5555
<Button title="Disabled Icon only Button" icon="calendar" disabled />
5656
<Button title="Button with Icon only" icon="calendar" />
Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
1-
<IconPrimary icon="question" />
2-
<IconPrimary icon="question_medium" />
3-
<IconPrimary icon="question" size="medium" />
4-
<Button variant="secondary" size="large">
5-
<IconPrimary icon="question_medium" size="large" />
6-
</Button>
1+
<IconPrimary icon="question" title="default size" />
2+
<IconPrimary icon="question_medium" title="medium size in icon name" />
3+
<IconPrimary
4+
icon="question"
5+
size="medium"
6+
title="medium size defined in size prop"
7+
/>
8+
<IconPrimary
9+
icon="question"
10+
size="40"
11+
title="default sized icon with custom size"
12+
/>

packages/dnb-ui-lib/src/components/button/Example.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,15 +51,15 @@ class Example extends PureComponent {
5151
<Button
5252
text="Primary button with icon"
5353
title="This is a button title"
54-
icon="chevron-right"
54+
icon="chevron_right"
5555
/>
5656
</div>
5757
<div className="example-box">
5858
<Button
5959
text="Primary button with icon on left"
6060
title="This is a button title"
6161
icon_position="left"
62-
icon="chevron-left"
62+
icon="chevron_left"
6363
/>
6464
</div>
6565
<div className="example-box">
@@ -68,7 +68,7 @@ class Example extends PureComponent {
6868
text="Tertiary button with icon on left"
6969
title="This is a button title"
7070
icon_position="left"
71-
icon="chevron-left"
71+
icon="chevron_left"
7272
/>
7373
</div>
7474
<div className="example-box">
@@ -77,7 +77,7 @@ class Example extends PureComponent {
7777
text="Tertiary button with icon on left"
7878
title="This is a button title"
7979
icon_position="left"
80-
icon="chevron-left"
80+
icon="chevron_left"
8181
disabled
8282
/>
8383
</div>
@@ -87,7 +87,7 @@ class Example extends PureComponent {
8787
href="?no-cache=1"
8888
title="This is a link"
8989
icon_position="right"
90-
icon="chevron-right"
90+
icon="chevron_right"
9191
/>
9292
</div>
9393
<div className="example-box">

packages/dnb-ui-lib/src/components/button/__tests__/Screenshot.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ describe.skip('Button screenshot', () => {
3838
3939
-> Syntax
4040
<div className="button-wrapper">
41-
<Button text="Next" variant="secondary" icon="chevron-right" />
41+
<Button text="Next" variant="secondary" icon="chevron_right" />
4242
</div>
4343
4444
-> Styling

packages/dnb-ui-lib/src/components/dropdown/__tests__/__snapshots__/Dropdown.test.js.snap

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,8 @@ exports[`Dropdown scss have to match snapshot 1`] = `
345345
.dnb-icon--custom-size {
346346
width: auto;
347347
height: auto; }
348-
.dnb-icon svg:not([width]):not([height]) {
348+
.dnb-icon svg:not([width]):not([height]),
349+
.dnb-icon img:not([width]):not([height]) {
349350
width: inherit;
350351
height: inherit; }
351352

packages/dnb-ui-lib/src/patterns/action-nav/ActionNav.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ export default class ActionNav extends PureComponent {
120120
title={prev_title}
121121
variant="secondary"
122122
icon_position="left"
123-
icon="chevron-left"
123+
icon="chevron_left"
124124
href={prev_href}
125125
/>
126126
</div>
@@ -132,7 +132,7 @@ export default class ActionNav extends PureComponent {
132132
text={next_text}
133133
title={next_title}
134134
variant="primary"
135-
icon="chevron-right"
135+
icon="chevron_right"
136136
href={next_href}
137137
/>
138138
</div>

packages/dnb-ui-lib/src/patterns/summary-table/SummaryTable.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export default class SummaryTable extends PureComponent {
115115
title={prev_title}
116116
variant="secondary"
117117
icon_position="left"
118-
icon="chevron-left"
118+
icon="chevron_left"
119119
href={prev_href}
120120
/>
121121
</div>
@@ -127,7 +127,7 @@ export default class SummaryTable extends PureComponent {
127127
text={next_text}
128128
title={next_title}
129129
variant="primary"
130-
icon="chevron-right"
130+
icon="chevron_right"
131131
href={next_href}
132132
/>
133133
</div>

0 commit comments

Comments
 (0)