Update devcontainer feature to use containerEnv instead of remoteEnv#38
Merged
Update devcontainer feature to use containerEnv instead of remoteEnv#38
Conversation
The devcontainer-feature.json schema does not permit remoteEnv as a top-level property; the release workflow's metadata validation rejects it. Switch to containerEnv, which is the supported way for a feature to contribute environment variables to the container and matches the intent already documented in AGENTS.md.
Mirrors the rename from remoteEnv to containerEnv in devcontainer-feature.json so the consistency check still verifies SSL_CERT_DIR against the sslCertDirs default.
Adds a validate-only step to the feature CI job that invokes the same metadata validator the release workflow uses (Ajv strict mode against the official feature schema). This catches schema violations like the recent remoteEnv top-level property on every PR rather than only at release time.
dnegstad
added a commit
that referenced
this pull request
May 5, 2026
* Set SSL_CERT_DIR from install.sh instead of containerEnv The containerEnv entry added in #38 used `${containerEnv:HOME}` as a substitution, which is unresolvable at containerEnv bake time, leaving SSL_CERT_DIR with an empty HOME prefix on existing containers. remoteEnv isn't valid in a feature under strict-schema validation, so move SSL_CERT_DIR setup into install.sh: write /etc/profile.d for login shells (per-user $HOME expansion) and /etc/environment for PAM logins (resolved _REMOTE_USER_HOME). Single uniform code path covers default and user-overridden sslCertDirs. * Bump version to 1.0.1 Drop the -pre suffix on the feature manifest and all package.json files so this PR can ship as a stable 1.0.1 release immediately on merge. --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the devcontainer-dev-certs feature configuration to use the
containerEnvproperty instead of the deprecatedremoteEnvproperty for setting environment variables.Key Changes
remoteEnvtocontainerEnvin the devcontainer feature configurationDetails
This change aligns with the current devcontainer specification where
containerEnvis the standard property for defining environment variables that should be set in the container. TheremoteEnvproperty is deprecated in favor ofcontainerEnv.https://claude.ai/code/session_01WbfCJpvYyJwWVe44tXM7cz