Fix table column misalignment in GUI Emacs#170
Merged
Conversation
Inline markdown faces (e.g. md-ts-code) inherit from fixed-pitch, which uses a different font than the default face. Since padding is character-counted but rendering is pixel-based, columns drifted whenever a cell contained styled text like backtick literals. Resolve each face in table display strings to an anonymous plist that retains only visual attributes (foreground, weight, slant) and drops font-identity ones (family, height). All table text now renders in the buffer's default font; colors survive. Follows up on #167.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline markdown faces like
md-ts-codeinherit fromfixed-pitch, which uses a different font than the default face in GUI Emacs. Since table padding is character-counted but rendering is pixel-based, columns drifted whenever a cell contained styled text like backtick literals.This resolves each face in table display strings to an anonymous plist that retains only visual attributes (foreground, weight, slant) and drops font-identity ones (family, height). All table text now renders in the buffer's default font; colors survive.
Follows up on #167.