Soft-dedicate the input window so display-buffer leaves it alone#174
Merged
Soft-dedicate the input window so display-buffer leaves it alone#174
Conversation
Packages like magit, help, and compilation call display-buffer to show their buffers. Emacs picks a target window by walking the fallback action chain, which considers every non-dedicated window. Because the input window was never marked dedicated, it was a valid target—particularly when it happened to be the least recently used window in a multi-window frame. Calling set-window-dedicated-p with the value 'side tells Emacs to skip this window for display-buffer, while still permitting switch-to-buffer and other-window to reach it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages like magit, help, and compilation call display-buffer to
show their buffers. Emacs picks a target window by walking the
fallback action chain, which considers every non-dedicated window.
Because the input window was never marked dedicated, it was a valid
target—particularly when it happened to be the least recently used
window in a multi-window frame.
Calling set-window-dedicated-p with the value 'side tells Emacs to
skip this window for display-buffer, while still permitting
switch-to-buffer and other-window to reach it.