refactor: unify session status tracking into single pi--status variable#21
Merged
refactor: unify session status tracking into single pi--status variable#21
Conversation
Previously, session activity state was tracked in two places: - pi--status (buffer-local symbol: idle/sending/streaming/compacting) - :is-streaming in pi--state plist (boolean) This duplication was error-prone and confusing. Now: - pi--status is the single source of truth, defined in pi-core.el - pi--update-state-from-event sets status on agent_start/agent_end - pi--extract-state-from-response returns :status for initialization - :is-streaming and :is-compacting removed from pi--state plist Benefits: - Clearer code: one variable to check, not two - Status set atomically in event handler, not scattered in display functions - Tests are simpler and more focused
dnouri
force-pushed
the
refactor/unify-status-tracking
branch
from
1f6f52d to
35cd0a5
Compare
dnouri
added a commit
that referenced
this pull request
Feb 25, 2026
…le (#21) Previously, session activity state was tracked in two places: - pi--status (buffer-local symbol: idle/sending/streaming/compacting) - :is-streaming in pi--state plist (boolean) This duplication was error-prone and confusing. Now: - pi--status is the single source of truth, defined in pi-core.el - pi--update-state-from-event sets status on agent_start/agent_end - pi--extract-state-from-response returns :status for initialization - :is-streaming and :is-compacting removed from pi--state plist Benefits: - Clearer code: one variable to check, not two - Status set atomically in event handler, not scattered in display functions - Tests are simpler and more focused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, session activity state was tracked in two places:
pi--status(buffer-local symbol: idle/sending/streaming/compacting):is-streaminginpi--stateplist (boolean)This duplication was error-prone and confusing.
Changes
pi--statusis now the single source of truth, defined inpi-core.elpi--update-state-from-eventsets status onagent_start/agent_endeventspi--extract-state-from-responsereturns:statusfor initialization from server:is-streamingand:is-compactingremoved frompi--stateplistBenefits
Testing