feat: display inline images from tool results in chat buffer#221
Open
conornash wants to merge 1 commit into
Open
feat: display inline images from tool results in chat buffer#221conornash wants to merge 1 commit into
conornash wants to merge 1 commit into
Conversation
When a tool (e.g. read) returns image content blocks alongside text, the images are now rendered inline inside the tool block overlay. In GUI Emacs: decoded and displayed via create-image/insert-image with max-width/max-height scaling to fit the window. In terminal Emacs: a text placeholder showing MIME type and size. Implementation: - New struct slot: tool-block.image-blocks stores content for toggle - pi-coding-agent--mime-to-image-type: MIME string to Emacs type symbol - pi-coding-agent--insert-inline-image: decode + insert or placeholder - pi-coding-agent--insert-tool-images: iterate content, insert images - display-tool-end: calls insert-tool-images after text rendering - toggle-tool-output: re-inserts images from stored blocks after toggle Handles: corrupt base64, unknown MIME types, empty data, vectors and lists, multiple image blocks, image-only results (no text). 12 new tests covering all paths. 942/942 full suite passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a tool (e.g. read) returns image content blocks alongside text, the images are now rendered inline inside the tool block overlay.
In GUI Emacs: decoded and displayed via create-image/insert-image with max-width/max-height scaling to fit the window.
In terminal Emacs: a text placeholder showing MIME type and size.
Implementation:
Handles: corrupt base64, unknown MIME types, empty data, vectors and lists, multiple image blocks, image-only results (no text).
12 new tests covering all paths. 942/942 full suite passes.