Implement get_domain_registration and get_domain_renewal APIs#147
Merged
1 commit merged intoMar 3, 2023
Merged
Conversation
ghost
self-assigned this
ghost
requested review from
ggalmazor and
sbastn
and removed request for
a team,
ggalmazor and
sbastn
ggalmazor
approved these changes
Mar 2, 2023
Contributor
ggalmazor
left a comment
ggalmazor
left a comment
There was a problem hiding this comment.
Thanks for working on this, @wilson-dnsimple! I love seeing other people contributing to this client :)
DXTimer
approved these changes
Mar 3, 2023
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the get_domain_registration and get_domain_renewal methods on the Registrar class.