Add support for registrant APIs#159
Merged
8 commits merged intoAug 31, 2023
Merged
Conversation
ghost
self-requested a review
DXTimer
requested changes
Aug 22, 2023
Contributor
DXTimer
left a comment
DXTimer
left a comment
There was a problem hiding this comment.
Only the create registrant change endpoint has been added please add all 5 endpoints for the registrant change API: list, check, create, show, delete.
Tests are missing.
The code should be moved out of the Registrar.java file into its own file.
ghost
changed the title
added 2 commits
August 30, 2023 13:10
DXTimer
approved these changes
Aug 30, 2023
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces 5 new endpoints that are part of the domain contact management API that was introduced in dnsimple/dnsimple-developer#501.
The following endpoints have been added:
/{account}/registrar/registrant_changes/{account}/registrar/registrant_changes/{account}/registrar/registrant_changes/check/{account}/registrar/registrant_changes/{registrantchange}/{account}/registrar/registrant_changes/{registrantchange}Belongs to https://github.com/dnsimple/dnsimple-business/issues/1729