Skip to content

Conversation

@johanix
Copy link
Collaborator

@johanix johanix commented Jan 15, 2026

Summary by CodeRabbit

  • New Features

    • New CLI subcommand now available.
  • Chores

    • Updated local development dependency version.

✏️ Tip: You can customize this high-level summary in your review settings.

@johanix johanix requested a review from a team as a code owner January 15, 2026 10:34
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 15, 2026

📝 Walkthrough

Walkthrough

Registers a new EdmCmd subcommand with the root command and bumps the github.com/dnstapir/tapir dependency version in go.mod.

Changes

Cohort / File(s) Summary
Command Registration
cmd/root.go
Added rootCmd.AddCommand(cmd.EdmCmd) to register the new Edm subcommand.
Dependency Version
go.mod
Updated github.com/dnstapir/tapir module version to v0.0.0-20260115113810-71a904f35f68.

Sequence Diagram(s)

(omitted — changes are small and don't introduce multi-component control flow)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • eest

Poem

🐇 I hop a tiny change so spry,
EdmCmd now leaps into the sky.
A tapir version gets a nudge,
Small code steps, a brief little judge.
Hooray — the CLI grows by and by. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title mentions 'dnstapir-cli edm stats' command which directly relates to the changes adding EdmCmd registration and updating dependencies for this feature.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@go.mod`:
- Around line 5-6: The go.mod currently has a local replace directive "replace
github.com/dnstapir/tapir => ../tapir" which breaks CI; remove that replace
directive from go.mod before merging and either update the require for
github.com/dnstapir/tapir to the published version you need or keep the PR as a
draft until the tapir changes are published so CI can resolve the dependency.
📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c1c334 and aa24686.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • cmd/root.go
  • go.mod
🧰 Additional context used
🪛 GitHub Actions: Build
cmd/root.go

[error] 16-16: Build failed: replacement directory '../tapir' does not exist for github.com/dnstapir/tapir@v0.0.0-20251029102003-58142cabe113 during go build.

🔇 Additional comments (1)
cmd/root.go (1)

57-59: EdmCmd registration follows the established pattern.

The command registration at line 58 is consistent with how PopCmd, DawgCmd, ApiCmd, FilterlistsCmd, EnrollCmd, and RenewCmd are added. The syntax is identical and the import source matches other commands. The go.mod replacement for github.com/dnstapir/tapir is properly configured pointing to the local ../tapir directory.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

@oej
Copy link
Member

oej commented Jan 15, 2026

Don't forget to update techdocs

@zluudg zluudg merged commit 071d720 into main Jan 27, 2026
3 checks passed
@zluudg zluudg deleted the edm-stats-1 branch January 27, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants