Skip to content

Eis#10

Merged
aleksandarbabicdnv merged 4 commits intomainfrom
eis
Apr 29, 2026
Merged

Eis#10
aleksandarbabicdnv merged 4 commits intomainfrom
eis

Conversation

@eisDNV
Copy link
Copy Markdown
Collaborator

@eisDNV eisDNV commented Apr 28, 2026

Added explicit time in AntiPendulumEnvironment, so that this can be used in do_step(current_time, step_size) function. Previously 'steps' were used which is wrong when step_size != 1.0

eisDNV added 3 commits April 27, 2026 13:28
…. Moved 'intervals' to test_q as the parameter was only used to demonstrate resumed learning and is not used during normal training
…gument, not steps. The old version was incorrect for self.dt!=1.0
Comment thread tests/test_q.py
Comment thread scripts/train_q.py
Comment thread src/crane_controller/q_agent.py Outdated
Comment thread scripts/train_q.py Outdated
Comment thread scripts/train_q.py Outdated
Comment thread tests/test_q.py Outdated
Comment thread src/crane_controller/envs/controlled_crane_pendulum.py
Copy link
Copy Markdown
Collaborator

@aleksandarbabicdnv aleksandarbabicdnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now. There are some minor things - but ruff did not complain.

@aleksandarbabicdnv aleksandarbabicdnv merged commit 2ca8009 into main Apr 29, 2026
10 checks passed
@aleksandarbabicdnv aleksandarbabicdnv deleted the eis branch April 29, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants