Conversation
This commit introduces improved theming with dedicated theme files and variables for light/dark modes, alongside CSS splitting capabilities. It also restructures configuration and debugging for enhanced clarity, updates eslint configurations, and integrates a CSS combination script for optimized builds.
Added comments to clarify the purpose and structure of CSS files, including descriptions for variables and components. Enhanced imports and module exports for better readability and maintainability.
This commit upgrades various dependencies, improves server-side rendering support, and ensures a consistent fallback UI for components like `Guide` and `Baseline`. It introduces a new `ClientOnly` utility, enhances measurement handling, and replaces auto-fit with auto-fill for grid templates.
…rification. This commit implements several structural improvements and optimizations, including reducing export scope to only essential components, types, and utilities, while keeping internal functionalities private. Component and utility functions were modified to improve consistency, and `useIsClient` and `ClientOnly` are now internalized. Additionally, workflow updates were introduced to verify package contents during CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request involves a major update to the
baseline-kitpackage, focusing on a comprehensive redesign of the component library, enhanced theming options, and various improvements to the build and linting configurations. Below are the most important changes:Major Changes to Component Library and Theming:
README.md: Updated documentation to include new CSS import options, integration steps for frameworks like Remix, and detailed theming options. [1] [2] [3] [4]CHANGELOG.md: Added a new section for version 3.0.0, highlighting the comprehensive component library redesign and improved theming system.Build and Configuration Enhancements:
package.json: Updated build scripts to include a newbuild:combine-cssstep and added new dependencies for updated ESLint and TypeScript configurations. [1] [2] [3] [4] [5] [6]scripts/combine-css.js: New script to combine core and theme CSS files into a singlebaseline-kit.cssfile and copy individual theme files to the distribution directory.Linting Configuration Updates:
.eslintignore: Removed unnecessary entries to clean up the ignore list..eslintrc.cjs: Removed the old ESLint configuration file.eslint.config.js: Added a new ESLint configuration file using the latest plugins and settings for TypeScript and React.Workflow Improvements:
.github/workflows/test.yml: Added a new step to verify package contents during the CI workflow.Codebase Simplification:
src/components/Baseline/Baseline.tsx: Refactored utility imports and removed unnecessary exports to simplify the codebase. [1] [2] [3]