Skip to content

polish map search controls#85

Merged
dnywh merged 4 commits into
mainfrom
dnywh/polish-map-dialog-controls
May 14, 2026
Merged

polish map search controls#85
dnywh merged 4 commits into
mainfrom
dnywh/polish-map-dialog-controls

Conversation

@dnywh
Copy link
Copy Markdown
Owner

@dnywh dnywh commented May 14, 2026

Summary

  • remove the floating close button from the map search palette
  • make the map control focus state visible with an inset ring that is not clipped by the zoom group
  • add production e2e coverage for keyboard focus, Escape dismissal, and the absence of the extra close button

Validation

  • npm run check
  • npm run test:e2e:prod -- e2e/map.spec.ts

@vercel
Copy link
Copy Markdown

vercel Bot commented May 14, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
peels Ready Ready Preview, Comment May 14, 2026 4:48am

@dnywh dnywh requested a review from Copilot May 14, 2026 04:22
@supabase
Copy link
Copy Markdown

supabase Bot commented May 14, 2026

This pull request has been ignored for the connected project mfnaqdyunuafbwukbbyr because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

Copilot AI reviewed May 14, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR polishes the map search and map control experience by removing the extra palette close button, changing map control focus styling, and extending production e2e coverage for the updated behavior.

Changes:

  • Removed the floating close button from the map search dialog.
  • Updated map control focus styling to use an inset box-shadow ring.
  • Added e2e assertions for keyboard focus styling, Escape dismissal, and absence of the removed close button.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/features/map/components/MapSearch.tsx Removes the dialog close button and unused translation/imports.
src/features/map/components/MapControls.tsx Refactors control shadow styling and adds inset focus-visible styling.
e2e/map.spec.ts Adds production e2e coverage for keyboard focus and search dialog dismissal behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/features/map/components/MapControls.tsx Outdated
outline: none;
box-shadow:
inset 0 0 0 2px ${theme.colors.focus.outline},
var(--map-control-shadow, none);
@dnywh dnywh requested a review from Copilot May 14, 2026 04:29
Copilot AI reviewed May 14, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comment thread e2e/map.spec.ts
.evaluate((element) => getComputedStyle(element).boxShadow)
)
.toContain("inset");

Comment thread e2e/map.spec.ts Outdated
Comment on lines +291 to +293
page.getByTestId("map-search-dialog").getByRole("button", {
name: "Close",
})
Comment thread src/features/map/components/MapControls.tsx
outline: none;
box-shadow:
inset 0 0 0 2px ${theme.colors.focus.outline},
var(--map-control-shadow, 0 0 0 0 transparent);
@dnywh dnywh requested a review from Copilot May 14, 2026 04:36
Copilot AI reviewed May 14, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread e2e/map.spec.ts Outdated
const searchInput = page.getByTestId("geocoding-search-input");
await expect(searchInput).toBeFocused();
await expect(
page.getByTestId("map-search-dialog").locator(":scope > button")
@dnywh dnywh requested a review from Copilot May 14, 2026 04:47
Copilot AI reviewed May 14, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@dnywh dnywh merged commit 6368f89 into main May 14, 2026
10 checks passed
@dnywh dnywh deleted the dnywh/polish-map-dialog-controls branch May 14, 2026 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dnywh