fix: use extended regex in install.sh for macOS sed compatibility#25
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Java version detection failing on macOS due to BSD sed incompatibility. The sed command used \? (a GNU basic regex extension) which silently fails on macOS BSD sed, causing version parsing to return empty results. The fix changes both sed calls to use -E (extended regex) with proper extended syntax, making the script portable across both macOS and Linux.
Changes:
- Converted two
sedcommands from basic regex with GNU extensions to POSIX-compliant extended regex using-Eflag - Changed
\?(GNU extension) to?and removed backslashes from parentheses to match extended regex syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sedcommand used\?(GNU basic regex extension) which is not supported by macOS BSDsed, causing the version parsing to silently failsedcalls to use-E(extended regex), which works on both macOS and LinuxTest plan
bash install.shon macOS — should show "Java 17 found"