Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Conversation

@ddgenome
Copy link
Contributor

No description provided.

@ddgenome ddgenome requested a review from cdupuis October 12, 2020 13:26
@atomist atomist bot added auto-branch-delete:on-close Delete branch when pull request gets closed auto-merge-method:merge Auto-merge with merge commit auto-merge:on-approve Auto-merge on review approvals labels Oct 12, 2020
Copy link
Contributor

@cdupuis cdupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is correct in of itself but it is not going to work right now because skill-runner does not have support the generic npm registry provider. That's need to be added before merging this.

@cdupuis cdupuis added the changelog:added Add this issue or pull request to added changelog section label Oct 14, 2020
@cdupuis cdupuis changed the title Use generic NPM registry Use generic npm registry Oct 14, 2020
@cdupuis cdupuis merged commit a684f85 into main Oct 14, 2020
@atomist atomist bot deleted the npm-registry branch October 14, 2020 14:35
atomist bot pushed a commit that referenced this pull request Oct 14, 2020
[atomist:generated]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

auto-branch-delete:on-close Delete branch when pull request gets closed auto-merge:on-approve Auto-merge on review approvals auto-merge-method:merge Auto-merge with merge commit changelog:added Add this issue or pull request to added changelog section

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants