This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Format version time as in docker/cli#223
Merged
vdemeester merged 1 commit intodocker-archive-public:masterfrom Jun 13, 2018
chris-crone:version-time
Merged
Format version time as in docker/cli#223vdemeester merged 1 commit intodocker-archive-public:masterfrom chris-crone:version-time
vdemeester merged 1 commit intodocker-archive-public:masterfrom
chris-crone:version-time
Conversation
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 47.4% 46.08% -1.33%
==========================================
Files 39 39
Lines 2757 2719 -38
==========================================
- Hits 1307 1253 -54
- Misses 1249 1262 +13
- Partials 201 204 +3
Continue to review full report at Codecov.
|
vdemeester
approved these changes
Jun 13, 2018
| return strings.Join(res, "\n") | ||
| } | ||
|
|
||
| // FIXME(chris-crone): use function in docker/cli/cli/command/system/version.go. |
mat007
reviewed
Jun 13, 2018
| // FIXME(chris-crone): use function in docker/cli/cli/command/system/version.go. | ||
| func reformatDate(buildTime string) string { | ||
| t, errTime := time.Parse(time.RFC3339Nano, buildTime) | ||
| if errTime == nil { |
Contributor
Author
There was a problem hiding this comment.
Copypasta'd this from docker/cli but yes, err would be sufficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #189