This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Proposal: Remove the *no .dockerapp* magic…#331
Merged
chris-crone merged 1 commit intodocker-archive-public:masterfrom Aug 20, 2018
Merged
Proposal: Remove the *no .dockerapp* magic…#331chris-crone merged 1 commit intodocker-archive-public:masterfrom
chris-crone merged 1 commit intodocker-archive-public:masterfrom
Conversation
With this, an app *has to* end-up with `.dockerapp`, even for images. This means, `docker-app render foo` will always look for `foo.dockerapp`, *never* for a folder or file called `foo`. - This behavior is currently broken - It makes the behavior a bit weird/inconsistent. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
- Coverage 53.41% 53.37% -0.04%
==========================================
Files 50 50
Lines 2902 2900 -2
==========================================
- Hits 1550 1548 -2
Misses 1125 1125
Partials 227 227
Continue to review full report at Codecov.
|
Contributor
|
This clashes a bit with #320 and the intentions there. Worth chatting to @chris-crone. |
vdemeester
changed the title
Contributor
Author
|
@garethr this is just for the "files" for now, but yeah |
Contributor
|
Since this is for files only and we haven't yet prioritised #320, I'm OK with this. |
chris-crone
approved these changes
Aug 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this, an app has to end-up with
.dockerapp, even for images.This means,
docker-app render foowill always look forfoo.dockerapp, never for a folder or file calledfoo.