This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Fix helm generation#335
Merged
vdemeester merged 1 commit intodocker-archive-public:masterfrom Aug 2, 2018
Merged
Conversation
vdemeester
force-pushed
the
fix-helm-generation
branch
2 times, most recently
from
fb1c8d4 to
aae527e
Compare
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
- Coverage 56.13% 56.05% -0.08%
==========================================
Files 50 50
Lines 2551 2551
==========================================
- Hits 1432 1430 -2
- Misses 913 914 +1
- Partials 206 207 +1
Continue to review full report at Codecov.
|
mnottale
approved these changes
Aug 2, 2018
silvin-lubecki
suggested changes
Aug 2, 2018
Contributor
silvin-lubecki
left a comment
silvin-lubecki
left a comment
There was a problem hiding this comment.
Waiting for docker/cli#1262 to be merged
This bump the docker/cli version to get the fix required on `ExtractVariables`. It now takes a pattern other than the default, which is something we require on `docker/app` as the pattern we use (when interpolating) is a bit different from the default one. It also adds a small message on the e2e test errors to see which file was wrong. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
fix-helm-generation
branch
from
aae527e to
f33314d
Compare
silvin-lubecki
approved these changes
Aug 2, 2018
| golden.Assert(t, string(chart), "helm-expected.chart/Chart.yaml") | ||
| golden.Assert(t, string(values), "helm-expected.chart/values.yaml") | ||
| golden.Assert(t, string(stack), "helm-expected.chart/templates/stack.yaml") | ||
| golden.Assert(t, string(chart), "helm-expected.chart/Chart.yaml", "chart file is wrong") |
Contributor
There was a problem hiding this comment.
and you should feel wrong!
"invalid chart file"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bump the docker/cli version to get the fix required on
ExtractVariables. It now takes a pattern other than the default,which is something we require on
docker/appas the pattern weuse (when interpolating) is a bit different from the default one.
It also adds a small message on the e2e test errors to see which file
was wrong.
Depends on docker/cli#1262
Signed-off-by: Vincent Demeester vincent@sbr.pm