Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Add render test with user settings#372

Merged
vdemeester merged 2 commits intodocker-archive-public:masterfrom
chris-crone:add-render-test
Sep 4, 2018
Merged

Add render test with user settings#372
vdemeester merged 2 commits intodocker-archive-public:masterfrom
chris-crone:add-render-test

Conversation

@chris-crone
Copy link
Copy Markdown
Contributor

- What I did

Added a render test for func Render(app *types.App, env map[string]string) (*composetypes.Config, error) with user settings.

- How to verify it

Run go test ./render

- Description for the changelog

N/A

Signed-off-by: Christopher Crone <christopher.crone@docker.com>
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
Copy link
Copy Markdown
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 4, 2018

Codecov Report

Merging #372 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #372     +/-   ##
=========================================
- Coverage   56.61%   56.51%   -0.1%     
=========================================
  Files          55       55             
  Lines        3031     3031             
=========================================
- Hits         1716     1713      -3     
- Misses       1063     1065      +2     
- Partials      252      253      +1
Impacted Files Coverage Δ
types/settings/settings.go 92.06% <0%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 356151c...331bd13. Read the comment docs.

@vdemeester vdemeester merged commit fc098ab into docker-archive-public:master Sep 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants