Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

DirNameFromAppName: Accept a trailing '/'.#402

Merged
chris-crone merged 1 commit intodocker-archive-public:masterfrom
mnottale:accept-trailing-slash
Oct 4, 2018
Merged

DirNameFromAppName: Accept a trailing '/'.#402
chris-crone merged 1 commit intodocker-archive-public:masterfrom
mnottale:accept-trailing-slash

Conversation

@mnottale
Copy link
Copy Markdown
Contributor

@mnottale mnottale commented Oct 4, 2018

Signed-off-by: Matthieu Nottale matthieu.nottale@docker.com

- What I did

Accept a trailing slash in fully qualified app name. bash completion adds a trailing slash when completing a directory.

- How to verify it

docker-app render myapp.dockerapp/ now works

- Description for the changelog

  • The command line now accepts an application directory name with a trailing slash.

Signed-off-by: Matthieu Nottale <matthieu.nottale@docker.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 4, 2018

Codecov Report

Merging #402 into master will decrease coverage by 1.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
- Coverage   59.01%   57.84%   -1.17%     
==========================================
  Files          59       59              
  Lines        3401     3314      -87     
==========================================
- Hits         2007     1917      -90     
- Misses       1136     1139       +3     
  Partials      258      258
Impacted Files Coverage Δ
internal/names.go 100% <100%> (ø) ⬆️
pkg/yatee/yatee.go 67.11% <0%> (-5.43%) ⬇️
types/settings/settings.go 92.06% <0%> (-4.77%) ⬇️
internal/helm/helm.go 52.8% <0%> (-3.22%) ⬇️
internal/yaml/yaml.go 80% <0%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5555fd...4a20de5. Read the comment docs.

@chris-crone chris-crone merged commit 3825a37 into docker-archive-public:master Oct 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants