This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Refactor e2e tests to use "gotest.tools/fs" dir#459
Merged
silvin-lubecki merged 1 commit intodocker-archive-public:masterfrom Feb 12, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
=======================================
Coverage 66.42% 66.42%
=======================================
Files 51 51
Lines 2740 2740
=======================================
Hits 1820 1820
Misses 660 660
Partials 260 260Continue to review full report at Codecov.
|
rumpl
reviewed
Feb 8, 2019
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
ulyssessouza
force-pushed
the
refactor-e2e-tmp-fs
branch
from
02494e4 to
5c667be
Compare
ulyssessouza
changed the title
Contributor
Author
|
@rumpl @silvin-lubecki PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Refactor tests not to pollute the fs during the e2e execution
- How I did it
Refactor e2e tests to use "gotest.tools/fs" created dir instead of current folder
- How to verify it
By monitoring the creation of files with something like
inotifywait -r -m e2e- Description for the changelog
Refactor e2e tests to use "gotest.tools/fs" dir
- A picture of a cute animal (not mandatory but encouraged)
