This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Revert "Run fossa analysis in a distinct pipeline"#673
Merged
Conversation
|
Please sign your commits following these rules: $ git clone -b "revert-670-fossa" git@github.com:docker/app.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
43a51cb to
aa563c0
Compare
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
==========================================
+ Coverage 72.07% 72.19% +0.11%
==========================================
Files 52 52
Lines 2636 2636
==========================================
+ Hits 1900 1903 +3
+ Misses 492 490 -2
+ Partials 244 243 -1
Continue to review full report at Codecov.
|
glours
approved these changes
Oct 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #670
Fossa CI build isn't reported to Github as Jenkins github multibranch plugin has commit status context hardcoded : https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubNotificationContext.java#L150
Impacted files detection within a PR is someway broken as https://ci.docker.com/teams-dsg/job/dsg/job/app-fossa/view/change-requests/job/PR-655/1/console states
Stage "License Scan" skipped due to when conditionalwhile https://github.com/docker/app/pull/655/files do update dependencies and vendoring