Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Revert "Run fossa analysis in a distinct pipeline"#673

Merged
glours merged 1 commit intomasterfrom
revert-670-fossa
Oct 7, 2019
Merged

Revert "Run fossa analysis in a distinct pipeline"#673
glours merged 1 commit intomasterfrom
revert-670-fossa

Conversation

@ndeloof
Copy link
Copy Markdown
Contributor

@ndeloof ndeloof commented Oct 7, 2019

Reverts #670

Fossa CI build isn't reported to Github as Jenkins github multibranch plugin has commit status context hardcoded : https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubNotificationContext.java#L150

Impacted files detection within a PR is someway broken as https://ci.docker.com/teams-dsg/job/dsg/job/app-fossa/view/change-requests/job/PR-655/1/console states Stage "License Scan" skipped due to when conditional while https://github.com/docker/app/pull/655/files do update dependencies and vendoring

@GordonTheTurtle
Copy link
Copy Markdown

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "revert-670-fossa" git@github.com:docker/app.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 7, 2019

Codecov Report

Merging #673 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
+ Coverage   72.07%   72.19%   +0.11%     
==========================================
  Files          52       52              
  Lines        2636     2636              
==========================================
+ Hits         1900     1903       +3     
+ Misses        492      490       -2     
+ Partials      244      243       -1
Impacted Files Coverage Δ
types/parameters/parameters.go 96.82% <0%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6338683...aa563c0. Read the comment docs.

Copy link
Copy Markdown
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 5dbe6f4 into master Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants