This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Refactor to single Go daemon and add some infrastructure #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
For vendoring, I'm currently using the very cool gvt, but anything that dumps code in to the |
Contributor
Author
|
/cc @aduermael @gdevillele I had some time while on vacation last week! |
Contributor
Author
|
Also this overlaps with #52 |
Contributor
|
@dave-tucker cool! Don't worry about #52. We will probably hand pick what we want from it and drop that PR. |
Contributor
|
@dave-tucker amazing PR overall!! Could you please update the line 42 in the Makefile please? Thank you. |
Contributor
Author
|
@gdevillele done! thanks for the review! |
- Refactor proxy and setup to single `dockercraft` daemon - Automatically download the latest Docker release, remove the Docker binary from the repo - Use Golang 1.6 - Update to Docker 1.11.1 in the Dockerfile - Dockerize all the testing - Add test targets for checking our golang code - Build and Serve targets for testing changes - Address comments from go fmt and go lint - Add simple circle.yml for CircleCI Signed-off-by: Dave Tucker <dt@docker.com>
Signed-off-by: Gaetan de Villele <gdevillele@gmail.com> (cherry picked from commit 4e81969)
Contributor
Author
|
Thanks @gdevillele for helping backport those changes from #65! You're a 🌟 |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dockercraftdaemonbinary from the repo
Signed-off-by: Dave Tucker dt@docker.com