This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Set sysctl/Namespace kernel parameters within the container#38
Merged
Conversation
Contributor
Author
|
This is needed for moby/moby#19265 |
Contributor
|
I understand what the I don't have any problems adding a field if it's going to be used. |
Contributor
Contributor
Author
|
Done |
Contributor
|
LGTM |
| Tmpfs map[string]string `json:",omitempty"` // List of tmpfs (mounts) used for the container | ||
| UTSMode UTSMode // UTS namespace to use for the container | ||
| ShmSize int64 // Total shm memory usage | ||
| Sysctls map[string]string `json:",omitempty"` // List of Namesp |
Contributor
There was a problem hiding this comment.
oh, nitpick but does the comment match this? "List of Namesp"
Contributor
|
@rhatdan looks like you did a merge, not a rebase |
Need setup sysctls that are namespaced inside of containers before the container processes are executed. Signed-off-by: Dan Walsh <dwalsh@redhat.com>
Contributor
Author
|
@thaJeztah I think it is fixed now |
Contributor
Contributor
|
LGTM |
runcom
added a commit
that referenced
this pull request
Mar 3, 2016
Set sysctl/Namespace kernel parameters within the container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.