This repository was archived by the owner on Jul 18, 2025. It is now read-only.
add support of --fail-on Snyk flag#130
Merged
silvin-lubecki merged 1 commit intomainfrom Dec 1, 2020
Merged
Conversation
glours
added
status: on hold 💤
Contributor
Author
|
Wait for PM validation before merging this PR cc @nebuk89 and Marina (no github account? 🤔 ) |
glours
force-pushed
the
add-fail-on-flag
branch
from
1ae8807 to
13e8553
Compare
glours
force-pushed
the
add-fail-on-flag
branch
5 times, most recently
from
8fa522c to
8aacf01
Compare
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
glours
force-pushed
the
add-fail-on-flag
branch
from
8aacf01 to
526c9a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #129
- What I did
Add a new
--fail-onflag to support the same flag in Snyk CLI- How I did it
Add a new flag, check the 3 possible values and add this when needed to the Snyk CLI
- How to verify it
Run e2e tests, they checks both values and the change of the exit code when the flag is set
- Description for the changelog
Add support of Snyk
--fail-onflag- A picture of a cute animal (not mandatory)
