Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Add support of Snyk --group-issues flag for json output#135

Merged
glours merged 1 commit intomainfrom
add-group-issues-flag
Dec 7, 2020
Merged

Add support of Snyk --group-issues flag for json output#135
glours merged 1 commit intomainfrom
add-group-issues-flag

Conversation

@glours
Copy link
Copy Markdown
Contributor

@glours glours commented Dec 4, 2020

- What I did
Add the support of Snyk --group-issues flag to group vulnerabilities in json output

- How I did it
Add the flag in the command, check that it can only by used with the --json flag

- How to verify it
Added e2e tests

- Description for the changelog
Add the support of Snyk --group-issues flag to group vulnerabilities in json output

- A picture of a cute animal (not mandatory)
image

@glours glours added status: in progress ❇️ Currently being developed for a future release. enhancement ✨ A new feature suggestion or improvement upon an existing feature. labels Dec 4, 2020
@glours glours self-assigned this Dec 4, 2020
@glours glours force-pushed the add-group-issues-flag branch 2 times, most recently from bcd890b to 851cbd3 Compare December 4, 2020 15:26
Comment thread README.md Outdated
Comment thread vars.mk
@@ -1,5 +1,5 @@
# Pinned Versions
SNYK_DESKTOP_VERSION=1.424.4
SNYK_DESKTOP_VERSION=1.432.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mat007 we are bumping the docker scan snyk version

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do the PR on Pinata when this PR will be merged 😉

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to bump snyk in pinata anymore, just the scan-cli-plugin version.

Copy link
Copy Markdown
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
@glours glours force-pushed the add-group-issues-flag branch from 851cbd3 to f379034 Compare December 7, 2020 10:26
@glours glours merged commit 5a09266 into main Dec 7, 2020
@glours glours deleted the add-group-issues-flag branch December 7, 2020 10:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement ✨ A new feature suggestion or improvement upon an existing feature. status: in progress ❇️ Currently being developed for a future release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants