This repository was archived by the owner on Jul 18, 2025. It is now read-only.
fix: remove NopCloser to get the right content-length set#175
Merged
glours merged 1 commit intodocker-archive-public:mainfrom Nov 17, 2021
Merged
fix: remove NopCloser to get the right content-length set#175glours merged 1 commit intodocker-archive-public:mainfrom
glours merged 1 commit intodocker-archive-public:mainfrom
Conversation
Signed-off-by: Yves Brissaud <yves.brissaud@docker.com>
Contributor
|
CI is back to green 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fix the way we login so
content-lengthis set and login will succeed.- How I did it
Removed the
ioutil.NopCloster- How to verify it
e2e tests are green
- Description for the changelog
- A picture of a cute animal (not mandatory)