This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Adding compose build e2e test#1039
Merged
gtardif merged 1 commit intodocker-archive:mainfrom Dec 10, 2020
Merged
Conversation
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
gtardif
force-pushed
the
compose_build_e2e
branch
from
3b731a8 to
c806b75
Compare
rumpl
approved these changes
Dec 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guillaume Tardif guillaume.tardif@gmail.com
What I did
Added e2E tests for :
compose buildbuilding named image, unnamed imagecompose upre-building the image if they don't existNot yet tested :
compose updoes not rebuild if not needed. This requires #1025Related issue
Part of https://github.com/docker/dev-tooling-team/issues/258
(not mandatory) A picture of a cute animal, if possible in relation with what you did