This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Scan suggest message when compose build / compose up#1351
Merged
gtardif merged 6 commits intodocker-archive:mainfrom Feb 26, 2021
Merged
Scan suggest message when compose build / compose up#1351gtardif merged 6 commits intodocker-archive:mainfrom
gtardif merged 6 commits intodocker-archive:mainfrom
Conversation
82ffe5b to
17f8c02
Compare
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
17f8c02 to
bdc427c
Compare
aiordache
reviewed
Feb 25, 2021
| for _, image := range builtImages { | ||
| commands = append(commands, fmt.Sprintf("docker scan %s", image)) | ||
| } | ||
| allCommands := strings.Join(commands, ", ") |
Contributor
There was a problem hiding this comment.
Maybe output one scan command per line. Having all commands on one line would be confusing (unless we can pass all images to one scan command).
aiordache
reviewed
Feb 25, 2021
| type scanOptin struct { | ||
| Optin bool `json:"optin"` | ||
| } | ||
| data, err := ioutil.ReadFile("/tmp/dat") |
Contributor
There was a problem hiding this comment.
Should this filepath be scan/config.json?
Contributor
Author
There was a problem hiding this comment.
outch, of course, cp/paste error...
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
c873788 to
6dda260
Compare
aiordache
approved these changes
Feb 25, 2021
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
6dda260 to
c1373d2
Compare
Contributor
Author
|
Updated message after sync/confirmation by various teams: 'Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
docker compose build, and end of build section whendocker compose upDOCKER_SCAN_SUGGEST = falseand compose up:
Related issue
(not mandatory) A picture of a cute animal, if possible in relation with what you did