This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Fix shell out to docker-classic when invoking#154
Merged
Conversation
d4db5e2 to
a433677
Compare
a433677 to
d2648da
Compare
Contributor
Author
|
Discussed with @rumpl, I had to move some unit tests into e2e tests, as they were relying on |
rumpl
approved these changes
May 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
docker context inspect defaulttodocker-classic context inspect defaultwhen getting default context to populatecontext lsdockeranddocker-classicin the path (more real usersetup). This was causing
docker context inspect defaultto fail and display docker help.(not mandatory) A picture of a cute animal, if possible in relation with what you did
