Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Fix shell out to docker-classic when invoking#154

Merged
gtardif merged 1 commit intomasterfrom
fix_context_inspect_shellout
May 27, 2020
Merged

Fix shell out to docker-classic when invoking#154
gtardif merged 1 commit intomasterfrom
fix_context_inspect_shellout

Conversation

@gtardif
Copy link
Copy Markdown
Contributor

@gtardif gtardif commented May 27, 2020

What I did

  • Changed shellout invocation from docker context inspect default to docker-classic context inspect default when getting default context to populate context ls
  • Changed e2e tests to run with both docker and docker-classic in the path (more real user
    setup). This was causing docker context inspect default to fail and display docker help.

(not mandatory) A picture of a cute animal, if possible in relation with what you did
image

@gtardif gtardif force-pushed the fix_context_inspect_shellout branch 2 times, most recently from d4db5e2 to a433677 Compare May 27, 2020 14:06
@gtardif gtardif force-pushed the fix_context_inspect_shellout branch from a433677 to d2648da Compare May 27, 2020 14:12
@gtardif
Copy link
Copy Markdown
Contributor Author

gtardif commented May 27, 2020

Discussed with @rumpl, I had to move some unit tests into e2e tests, as they were relying on docker being in the path and actually being the "classic" docker version, in order to docker context inspect default. (and were overlapping a bit with existing e2e, I moved the golden files into e2e)

@gtardif gtardif merged commit e630ace into master May 27, 2020
@gtardif gtardif deleted the fix_context_inspect_shellout branch May 27, 2020 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants