This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Kill child process "docker-classic" on cancel#157
Merged
Conversation
…is will not forward Kill signal, impossible to intercept / process this one.
gtardif
force-pushed
the
kill_child_process_on_cancel
branch
from
3f73272 to
ea98a2d
Compare
rumpl
approved these changes
May 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Forward process signals to child process
docker-classic, so that ctrl-C docker will also terminatedocker-classic. Unfortunately, this will not foward the KILL signal, the parent cannot process the signal and forward it.Related issue
Desktop issue in https://github.com/docker/pinata/pull/13957
https://ci-next.docker.com/teams-desktop/job/desktop/job/desktop-test-single-pr-mac/60900/display/redirect
(not mandatory) A picture of a cute animal, if possible in relation with what you did
