This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Conversation
ndeloof
approved these changes
Aug 25, 2021
ulyssessouza
force-pushed
the
error-on-unsupported-flags
branch
3 times, most recently
from
6c0084c to
d18d5d3
Compare
ndeloof
approved these changes
Sep 13, 2021
mat007
reviewed
Sep 14, 2021
ulyssessouza
force-pushed
the
error-on-unsupported-flags
branch
from
d18d5d3 to
813d7fa
Compare
mat007
reviewed
Sep 14, 2021
mat007
reviewed
Sep 16, 2021
ulyssessouza
force-pushed
the
error-on-unsupported-flags
branch
from
ae290f9 to
eab85b4
Compare
This fixes project name's regexp Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
…nges Signed-off-by: Massimo Re Ferre <massimo@it20.info>
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
ulyssessouza
force-pushed
the
error-on-unsupported-flags
branch
from
eab85b4 to
fa7e063
Compare
ulyssessouza
force-pushed
the
error-on-unsupported-flags
branch
from
059d3cd to
02003f4
Compare
mat007
reviewed
Sep 17, 2021
| if err != nil { | ||
| return err | ||
| } | ||
| cc, err := s.Get(currentContext) |
Contributor
There was a problem hiding this comment.
Wouldn’t it be safer to load this (from disk) just once?
Contributor
Author
There was a problem hiding this comment.
I'll pass that in the context then
ulyssessouza
force-pushed
the
error-on-unsupported-flags
branch
2 times, most recently
from
cffd8f9 to
9138c31
Compare
ulyssessouza
force-pushed
the
error-on-unsupported-flags
branch
from
9138c31 to
dc7422e
Compare
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
Contributor
|
Ah sorry, I think I merged a bit hastily as they were some errors. 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add checks to ECS, ACI, and Kubernetes backends.
/test-kube
/test-aci
/test-ecs
/test-windows