Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

On GH Actions windows nodes, ensure there is no automatic docker login before running ACI E2E tests #953

Merged
gtardif merged 1 commit into from
Nov 23, 2020
Merged

On GH Actions windows nodes, ensure there is no automatic docker login before running ACI E2E tests #953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/optional-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,4 +141,7 @@ jobs:
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
run: make e2e-aci
# need to docker logout on windows nodes, it seems GHActions does a `docker login --user githubactions` specifically on windows nodes
run: |
docker logout
make e2e-aci