Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Added the capability to specify a DataCenter#624

Merged
chungers merged 1 commit intodocker-archive:masterfrom
thebsdbox:vSphereDatacenter
Jul 21, 2017
Merged

Added the capability to specify a DataCenter#624
chungers merged 1 commit intodocker-archive:masterfrom
thebsdbox:vSphereDatacenter

Conversation

@thebsdbox
Copy link
Copy Markdown
Contributor

@thebsdbox thebsdbox commented Jul 21, 2017

This adds the following capabilities:

  • A -datacenter flag to specify a datacenter.
  • The capability to define a "Datacenter" : "Production Web", in the json for committing to InfraKit.
  • Environment VAR VCDATACENTER to specify the datacenter to use.
    A warning when left to default, as you'll still suffer problems with vCenter linked mode.

This addresses #620

Signed-off-by: Dan Finneran daniel.finneran@gmail.com

Signed-off-by: Dan Finneran <daniel.finneran@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 21, 2017

Codecov Report

Merging #624 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
+ Coverage   46.84%   46.89%   +0.05%     
==========================================
  Files          87       87              
  Lines        6197     7787    +1590     
==========================================
+ Hits         2903     3652     +749     
- Misses       3000     3841     +841     
  Partials      294      294
Impacted Files Coverage Δ
pkg/template/defaults.go 62.5% <0%> (-8.93%) ⬇️
pkg/provider/google/plugin/instance/types/types.go 43.13% <0%> (-8.22%) ⬇️
pkg/types/spec.go 61.11% <0%> (-6.64%) ⬇️
pkg/types/hierarchy.go 73.91% <0%> (-6.09%) ⬇️
pkg/types/any.go 50% <0%> (-5.41%) ⬇️
pkg/store/swarm/swarm.go 62.68% <0%> (-4.59%) ⬇️
pkg/spi/event/types.go 59.52% <0%> (-4.58%) ⬇️
pkg/template/fetch.go 30.61% <0%> (-4.39%) ⬇️
pkg/provider/google/plugin/metadata/plugin.go 70.68% <0%> (-4.32%) ⬇️
pkg/template/util.go 60% <0%> (-3.64%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 224fd66...f4dce49. Read the comment docs.

Copy link
Copy Markdown
Contributor

@chungers chungers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chungers chungers merged commit 0ef1592 into docker-archive:master Jul 21, 2017
@thebsdbox thebsdbox deleted the vSphereDatacenter branch July 21, 2017 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants