This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[17.12] Ensure containers are stopped on daemon startup#366
Merged
seemethere merged 1 commit intodocker-archive:17.12from Dec 19, 2017
Merged
[17.12] Ensure containers are stopped on daemon startup#366seemethere merged 1 commit intodocker-archive:17.12from
seemethere merged 1 commit intodocker-archive:17.12from
Conversation
When the containerd 1.0 runtime changes were made, we inadvertantly removed the functionality where any running containers are killed on startup when not using live-restore. This change restores that behavior. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit e69127b) Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
Member
|
original PR; moby/moby#35805 |
Contributor
|
LGTM |
docker-jenkins
pushed a commit
that referenced
this pull request
Jul 26, 2019
FIXED retrieving GO_VERSION from the CLI dir Upstream-commit: fa4ab31 Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Sep 20, 2019
…12.9 [19.03 backport] Bump Golang 1.12.9 Upstream-commit: b2823e4609ccf4685d3efb329d149b7d0b8588d6 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
…ine_35805 [17.12] Ensure containers are stopped on daemon startup
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
FIXED retrieving GO_VERSION from the CLI dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry Pick
Cherry pick was clean
Original Text
When the containerd 1.0 runtime changes were made, we inadvertantly
removed the functionality where any running containers are killed on
startup when not using live-restore.
This change restores that behavior.
Signed-off-by: Brian Goff cpuguy83@gmail.com
(cherry picked from commit e69127b)
Signed-off-by: Eli Uriegas eli.uriegas@docker.com