This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[17.12] Fix event filter filtering on "or"#374
Merged
andrewhsu merged 1 commit intodocker-archive:17.12from Feb 13, 2018
Merged
[17.12] Fix event filter filtering on "or"#374andrewhsu merged 1 commit intodocker-archive:17.12from
andrewhsu merged 1 commit intodocker-archive:17.12from
Conversation
The event filter used two separate filter-conditions for "namespace" and "topic". As a result, both events matching "topic" and events matching "namespace" were subscribed to, causing events to be handled both by the "plugin" client, and "container" client. This patch rewrites the filter to match only if both namespace and topic match. Thanks to Stephen Day for providing the correct filter :) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 295bb09) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
cpuguy83
pushed a commit
to cpuguy83/docker-ce
that referenced
this pull request
Feb 7, 2018
Bump version to 17.08.0-dev Upstream-commit: 1338f11ee72521f9f1552fac4a1340990d3dd855 Component: cli
docker-jenkins
pushed a commit
that referenced
this pull request
Aug 15, 2019
Dockerfiles: remove unused GO_VERSION Upstream-commit: 16b78be Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Nov 6, 2019
…ingress_network [19.03 backport] Add TC to check dynamic subnet for ingress network Upstream-commit: 075a0201b96af7c023f22341a8876a50ecc1828b Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
…ix-namespace-filtering [17.12] Fix event filter filtering on "or"
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
Dockerfiles: remove unused GO_VERSION
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of moby/moby#35896 for 17.12.x
No conflicts
The event filter used two separate filter-conditions for "namespace" and "topic". As a result, both events matching "topic" and events matching "namespace" were subscribed to, causing events to be handled both by the "plugin" client, and "container" client.
This patch rewrites the filter to match only if both namespace and topic match.
Thanks to Stephen Day for providing the correct filter :)
Signed-off-by: Sebastiaan van Stijn github@gone.nl
(cherry picked from commit 295bb09)
Signed-off-by: Sebastiaan van Stijn github@gone.nl
@crosbymichael @stevvooe PTAL