Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[18.01] Download support of images with multi-arch manifest#380

Merged
andrewhsu merged 1 commit intodocker-archive:18.01from
andrewhsu:arm64
Jan 4, 2018
Merged

[18.01] Download support of images with multi-arch manifest#380
andrewhsu merged 1 commit intodocker-archive:18.01from
andrewhsu:arm64

Conversation

@andrewhsu
Copy link
Copy Markdown
Contributor

@andrewhsu andrewhsu commented Jan 4, 2018

building aarch64 static binaries with docker-ce 18.01 code is failing with error:

00:09:54 error: unknown manifest mediaType (library/buildpack-deps:jessie@sha256:dd86dced7c9cd2a724e779730f0a53f93b7ef42228d4344b25ce9a42a1486251): 'application/vnd.docker.distribution.manifest.list.v2+json'
00:09:56 The command '/bin/sh -c ./contrib/download-frozen-image-v2.sh /docker-frozen-images 	buildpack-deps:jessie@sha256:dd86dced7c9cd2a724e779730f0a53f93b7ef42228d4344b25ce9a42a1486251 	busybox:latest@sha256:bbc3a03235220b170ba48a157dd097dd1379299370e1ed99ce976df0355d24f0 	debian:jessie@sha256:287a20c5f73087ab406e6b364833e3fb7b3ae63ca0eb3486555dc27ed32c6e60 	hello-world:latest@sha256:be0cd392e45be79ffeffa6b05338b98ebb16c87b255f48e297ec7f98e123905c' returned a non-zero code: 1
00:09:56 Makefile:124: recipe for target 'build' failed
00:09:56 make[1]: *** [build] Error 1

this pr will backport what looks like the fix:

with cherry-pick of moby/moby@0af5db5:

$ git cherry-pick -s -x -Xsubtree=components/engine 0af5db5

no conflicts.

@arm64b @andrewhsu
Download support of images with multi-arch manifest
85c031e 
Currently we only support 'application/vnd.docker.distribution.manifest.v2+json'
manifest images download, with more multi-arch images used, we need to support
download images with 'application/vnd.docker.distribution.manifest.list.v2+json'
format(aka "fat manifest"), else we will fail to download those multi-arch ones.

This PR adds 'application/vnd.docker.distribution.manifest.list.v2+json' manifest
support, thus we can download both multi-arch and legacy images.

Signed-off-by: Dennis Chen <dennis.chen@arm.com>
(cherry picked from commit 0af5db5)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@andrewhsu andrewhsu added this to the 18.01.0 milestone Jan 4, 2018
thaJeztah
thaJeztah approved these changes Jan 4, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 4dd1acc into docker-archive:18.01 Jan 4, 2018
@andrewhsu andrewhsu deleted the arm64 branch January 4, 2018 01:20
docker-jenkins pushed a commit that referenced this pull request Sep 25, 2019
@docker-unir
Merge pull request #380 from thaJeztah/19.03_backport_bump_go_1.12.9
daefef5 
Merged with https://github.com/seemethere/unir
Upstream-commit: 21096e8a01273a3d0cc664c549ee656915cc9d8f
Component: packaging
docker-jenkins pushed a commit that referenced this pull request Sep 26, 2019
@kolyshkin
Merge pull request #380 from thaJeztah/18.09_backport_hn3000_fix_39981
7ab51d0 
[18.09 backport] Remove minsky and stallman
Upstream-commit: b070eef5b2db835ace04da7cf338f022e59b79f1
Component: engine
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@seemethere seemethere Awaiting requested review from seemethere

1 more reviewer

@thaJeztah thaJeztah thaJeztah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.01.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewhsu @thaJeztah @arm64b