This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[17.12] Re-validate Mounts on container start#391
Merged
andrewhsu merged 1 commit intodocker-archive:17.12from Feb 20, 2018
Merged
Conversation
Validation of Mounts was only performed on container _creation_, not on container _start_. As a result, if the host-path no longer existed when the container was started, a directory was created in the given location. This is the wrong behavior, because when using the `Mounts` API, host paths should never be created, and an error should be produced instead. This patch adds a validation step on container start, and produces an error if the host path is not found. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 7cb96ba) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @cpuguy83 PTAL |
docker-jenkins
pushed a commit
that referenced
this pull request
Oct 3, 2019
…t_docs_updates [19.03 backport] API: update docs that /session left experimental in V1.39 Upstream-commit: 2ae5cbcf05d3f9941032582e2931bfe268d87cdc Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
…ix-mount-creation-on-start [17.12] Re-validate Mounts on container start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
back port of moby/moby#35833 for 17.12
no conflicts
Validation of Mounts was only performed on container creation, not on
container start. As a result, if the host-path no longer existed
when the container was started, a directory was created in the given
location.
This is the wrong behavior, because when using the
MountsAPI, host pathsshould never be created, and an error should be produced instead.
This patch adds a validation step on container start, and produces an
error if the host path is not found.