Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[18.02] skip DockerTrustSuite tests for 18.02#397

Merged
seemethere merged 2 commits intodocker-archive:18.02from
andrewhsu:fix-tests
Jan 24, 2018
Merged

[18.02] skip DockerTrustSuite tests for 18.02#397
seemethere merged 2 commits intodocker-archive:18.02from
andrewhsu:fix-tests

Conversation

@andrewhsu
Copy link
Copy Markdown
Contributor

@andrewhsu andrewhsu commented Jan 24, 2018 •
edited
Loading

Seeing failures in DockerTrustSuite:

...
FAIL: docker_cli_build_test.go:4223: DockerTrustSuite.TestTrustedBuildTagFromReleasesRole
FAIL: docker_cli_build_test.go:4254: DockerTrustSuite.TestTrustedBuildTagIgnoresOtherDelegationRoles
FAIL: docker_cli_create_test.go:295: DockerTrustSuite.TestTrustedCreate
FAIL: docker_cli_create_test.go:331: DockerTrustSuite.TestTrustedCreateFromBadTrustServer
FAIL: docker_cli_create_test.go:321: DockerTrustSuite.TestTrustedIsolatedCreate
FAIL: docker_cli_pull_trusted_test.go:25: DockerTrustSuite.TestTrustedIsolatedPull
FAIL: docker_cli_pull_trusted_test.go:85: DockerTrustSuite.TestTrustedOfflinePull
FAIL: docker_cli_pull_trusted_test.go:14: DockerTrustSuite.TestTrustedPull
FAIL: docker_cli_pull_trusted_test.go:48: DockerTrustSuite.TestTrustedPullFromBadTrustServer
FAIL: docker_cli_pull_trusted_test.go:135: DockerTrustSuite.TestTrustedPullReadsFromReleasesRole
FAIL: docker_cli_push_test.go:284: DockerTrustSuite.TestTrustedPush
FAIL: docker_cli_push_test.go:368: DockerTrustSuite.TestTrustedPushWithIncorrectPassphraseForNonRoot
FAIL: docker_cli_run_test.go:3142: DockerTrustSuite.TestTrustedRun
FAIL: docker_cli_run_test.go:3171: DockerTrustSuite.TestTrustedRunFromBadTrustServer
...
OOPS: 20 passed, 14 FAILED
...

This PR will address it by ignoring those tests until they can be ported to the new testing thing.

This PR fixes the same notary mismatch issue from 17.10, 17.11, 17.12, and 18.01 caused by updated stderr output from docker/cli#636 Fix stdout and errors in image/trust

This pr is duplicate of #344 [17.12] update trust tests for 17.12

With cherry-pick e357107 and 5742bd3:

$ git cherry-pick -s -x e357107 5742bd3

No conflicts.

seemethere and others added 2 commits January 24, 2018 11:06
@seemethere @andrewhsu
Blacklist tests, will be rewritten later on
9d7b9c2 
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
(cherry picked from commit 4e81e4f)
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
(cherry picked from commit ec6b0a1)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
(cherry picked from commit fbfeceb)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
(cherry picked from commit e357107)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@riyazdf @andrewhsu
update integration-cli tests for stderr output
1a2098c 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
(cherry picked from commit 250b84e)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
(cherry picked from commit d256539)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
(cherry picked from commit 5742bd3)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@andrewhsu andrewhsu added this to the 18.02.0 milestone Jan 24, 2018
seemethere
seemethere approved these changes Jan 24, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seemethere seemethere changed the title WIP [18.02] skip DockerTrustSuite tests for 18.02 [18.02] skip DockerTrustSuite tests for 18.02 Jan 24, 2018
@andrewhsu
Copy link
Copy Markdown
Contributor Author

andrewhsu commented Jan 24, 2018

Looks like the failures are for a timeout on DockerSuite.TestAttachAfterDetach.

The DockerTrustSuite tests seem to all pass.

@seemethere seemethere merged commit 3b28f86 into docker-archive:18.02 Jan 24, 2018
@andrewhsu andrewhsu deleted the fix-tests branch January 24, 2018 21:08
@dnephin dnephin mentioned this pull request Feb 20, 2018
Closed
8 tasks
@andrewhsu andrewhsu mentioned this pull request Feb 22, 2018
Merged
docker-jenkins pushed a commit that referenced this pull request Oct 17, 2019
Merge pull request #397 from daixiang0/master
44c097c 
fixed erroneous use of "-eq" operator
Upstream-commit: ce87ec1
Component: packaging
docker-jenkins pushed a commit that referenced this pull request Oct 28, 2019
@andrewhsu
Merge pull request #397 from thaJeztah/19.03_backport_slirp4netns_san…
69e9b37 
…dbox

[19.03 backport] rootless: harden slirp4netns with mount namespace and seccomp
Upstream-commit: d91a85a9b53c397101a9b9ba75a4bf18b52c3ab1
Component: engine
akrasnov-drv pushed a commit to drivenets/docker-ce that referenced this pull request Apr 23, 2023
Merge pull request docker-archive#397 from daixiang0/master
ce87ec1 
fixed erroneous use of "-eq" operator
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@seemethere seemethere seemethere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.02.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewhsu @seemethere @riyazdf