This repository was archived by the owner on Oct 13, 2023. It is now read-only.
Fix to address regression caused by PR 30897#427
Closed
selansen wants to merge 1 commit intodocker-archive:18.02from
Closed
Fix to address regression caused by PR 30897#427selansen wants to merge 1 commit intodocker-archive:18.02from
selansen wants to merge 1 commit intodocker-archive:18.02from
Conversation
With the inclusion of PR 30897, creating service for host network fails in 18.02. Modified IsPreDefinedNetwork check and return NetworkNameError instead of errdefs.Forbidden to address this issue Signed-off-by: selansen <elango.siva@docker.com>
docker-jenkins
pushed a commit
that referenced
this pull request
Jan 16, 2020
…th_gelf_spec [19.03 backport] logger/gelf: Skip empty lines to comply with spec Upstream-commit: cf14fa7a233114525e8a21abe1e4fc153fae7d3a Component: engine
docker-jenkins
pushed a commit
that referenced
this pull request
Jan 22, 2020
update list of reviewers in unir config Upstream-commit: d06b56d Component: packaging
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
…ewers update list of reviewers in unir config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the inclusion of PR 30897, creating service for host network
fails in 18.02. Modified IsPreDefinedNetwork check and return
NetworkNameError instead of errdefs.Forbidden to address this issue
Signed-off-by: selansen elango.siva@docker.com
Please do not send pull requests to this docker/docker-ce repository.
We do, however, take contributions gladly.
See https://github.com/docker/docker-ce/blob/master/CONTRIBUTING.md
Thanks!