This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[17.12] update vndr of swarmkit to a7680ec#432
Closed
andrewhsu wants to merge 2 commits intodocker-archive:17.12from
andrewhsu:sk
Closed
[17.12] update vndr of swarmkit to a7680ec#432andrewhsu wants to merge 2 commits intodocker-archive:17.12from andrewhsu:sk
andrewhsu wants to merge 2 commits intodocker-archive:17.12from
andrewhsu:sk
Conversation
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Contributor
|
the changes to protobuf are just a weird import path changing thing. not sure how they got introduced, but they're part of a higher-level repository so vendoring that package isn't a concern, and if this builds fine then it works. |
Member
|
Not sure what went wrong in the s390x CI; |
Contributor
|
Also include moby/swarmkit#2519 in this ? @andrewhsu |
|
What about the failing ce-tests-s390x? |
docker-jenkins
pushed a commit
that referenced
this pull request
Feb 19, 2020
…2.17 [19.03 backport] Update Golang 1.12.17 Upstream-commit: 3a8cae1ae473097ace7150734d368acaab083c52 Component: packaging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brings in this change:
comparison of changes on the engine: moby/swarmkit@7598f7a...a7680ec
comparison of changes on the cli: moby/swarmkit@de950a7...a7680ec