This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[18.03] Fix --label behavior on run#446
Closed
vdemeester wants to merge 1 commit intodocker-archive:18.03from
vdemeester:backport-fix-run-label-flag-behavior
Closed
[18.03] Fix --label behavior on run#446vdemeester wants to merge 1 commit intodocker-archive:18.03from vdemeester:backport-fix-run-label-flag-behavior
--label behavior on run#446vdemeester wants to merge 1 commit intodocker-archive:18.03from
vdemeester:backport-fix-run-label-flag-behavior
Conversation
Commit 2b17f4c8a8caad552025edb05a73db683fb8a5c6 fixed the way empty labels are taken into account (i.e. not interpolated from environment variable), but it created a regression. `ValidateLabel` functions doesn't allow empty label value, but it has always been possible to pass an empty label via the cli (`docker run --label foo`). This fixes that by not validating the label flag. Signed-off-by: Vincent Demeester <vincent@sbr.pm> (cherry picked from commit 31dc5c0a9a8bdc11c7ad335aebb753ed527caa5a) Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Member
|
Backport of docker/cli#904 |
Contributor
Author
|
Closing this one in favor of #447 that fixes the tests with this backport too 😉 |
docker-jenkins
pushed a commit
that referenced
this pull request
Jan 23, 2020
[19.03 backport] builder-next: close build context upload on cancel Upstream-commit: 60220a48b26ca96928efcd6222bc8e4b0d254b1b Component: engine
docker-jenkins
pushed a commit
that referenced
this pull request
Mar 26, 2020
CentOS: fix failing repository on aarch64 (arm64) Upstream-commit: ac9bcdf Component: packaging
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
CentOS: fix failing repository on aarch64 (arm64)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of:
with cherry-pick of git commit docker/cli@31dc5c0:
$ git cherry-pick -s -x -Xsubtree=components/cli 31dc5c0
no conflicts.