This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[18.03] Fixes binary installation#454
Merged
andrewhsu merged 1 commit intodocker-archive:18.03from Mar 6, 2018
Merged
Conversation
Binary installation was broken after the hack/dockerfile/install-binaries script was removed. This remedies that. Signed-off-by: Eli Uriegas <eli.uriegas@docker.com> (cherry picked from commit 59164be) Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
seemethere
changed the title
andrewhsu
approved these changes
Mar 6, 2018
Contributor
There was a problem hiding this comment.
LGTM
this is needed because #450 was brought in which includes moby/moby#36449 which changes the way packages are built
Member
|
Ah; offending PR was moby/moby#36336 Sorry, didn’t realize the packaging scripts relied on that |
Contributor
Author
|
No worries @thaJeztah, luckily we had already fixed this in nightly builds so it was basically a non-issue |
Contributor
|
This needs to pass the |
Contributor
Author
|
It's true, was an oversight. I'll get a PR up to fix that |
Member
|
❤️ thanks @tianon @seemethere |
docker-jenkins
pushed a commit
that referenced
this pull request
Jan 23, 2020
[19.03 backport] Fix possible runtime panic in Lgetxattr Upstream-commit: 69098f05cf0f61a1e8ff5f21075adc45288166dd Component: engine
docker-jenkins
pushed a commit
that referenced
this pull request
Apr 21, 2020
…3.10 [19.03 backport] bump Golang 1.13.10 Upstream-commit: 7a9d665c0a9b2a0b84aa96757f69f51c04dfa045 Component: packaging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of docker/docker-ce-packaging#88
Cherry pick was clean
Original text:
Binary installation was broken after the
hack/dockerfile/install-binaries script was removed.
This remedies that.
Signed-off-by: Eli Uriegas eli.uriegas@docker.com
(cherry picked from commit 59164be)
Signed-off-by: Eli Uriegas eli.uriegas@docker.com