Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[18.03] Add missing error return for plugin creation.#479

Merged
andrewhsu merged 1 commit intodocker-archive:18.03from
thaJeztah:18.03-err_return
Apr 18, 2018
Merged

[18.03] Add missing error return for plugin creation.#479
andrewhsu merged 1 commit intodocker-archive:18.03from
thaJeztah:18.03-err_return

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

cherry-pick of moby/moby#36646 for 18.03.

git checkout -b 18.03-err_return upstream/18.03 
git cherry-pick -s -S -x -Xsubtree=components/engine 89a882e2f1706e567a8514209701892b40da7a62 

no conflicts

Copy link
Copy Markdown
Contributor

@anusha-ragunathan anusha-ragunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu added this to the 18.03.1 milestone Mar 27, 2018
@andrewhsu andrewhsu changed the title Add missing error return for plugin creation. [18.03] Add missing error return for plugin creation. Mar 27, 2018
Signed-off-by: Anusha Ragunathan <anusha.ragunathan@docker.com>
(cherry picked from commit 89a882e2f1706e567a8514209701892b40da7a62)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@andrewhsu andrewhsu merged commit 02e93e4 into docker-archive:18.03 Apr 18, 2018
@thaJeztah thaJeztah deleted the 18.03-err_return branch April 18, 2018 22:00
docker-jenkins pushed a commit that referenced this pull request Jun 14, 2018
Add --init option to `docker service create`
Upstream-commit: 70db8dee744735c9afac30f6a035374e63049441
Component: cli
silvin-lubecki pushed a commit to silvin-lubecki/docker-ce that referenced this pull request Jan 31, 2020
[18.03] Add missing error return for plugin creation.
docker-jenkins pushed a commit that referenced this pull request Jul 17, 2020
[19.03 backport] Update Golang 1.13.13
Upstream-commit: 49a7db32bd30b277e8a678a60fa84cb2badb3a83
Component: packaging
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants