This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Conversation
tifayuki
force-pushed
the
staging
branch
7 times, most recently
from
926c13d to
b240ece
Compare
tifayuki
force-pushed
the
prevent_retrying_on_401
branch
3 times, most recently
from
5d8e976 to
dfa60d3
Compare
| events.run_forever() | ||
| except dockercloud.AuthError as e: | ||
| logger.info("Auth error: %s, retry in 1 hour" % e) | ||
| time.sleep(3600) |
There was a problem hiding this comment.
Is it likely that the authentication credentials will be valid in 1 hour? Once they're bad, won't they be bad forever?
Contributor
Author
There was a problem hiding this comment.
@evanp
no, once a credential is invalid, it is bad forever. Sending a request with an invalid auth once per hour will not get you blocked by the server. However, if we make the container quits immediately, as many users run this image with autorestart, the container may retry with the bad auth many times in a short period of time, and you may get blocked by the server.
tifayuki
force-pushed
the
prevent_retrying_on_401
branch
from
44ac67b to
6765512
Compare
tifayuki
force-pushed
the
prevent_retrying_on_401
branch
from
6765512 to
7fc4eea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.