Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[19.03 backport] Windows: fix error-type for starting a running container#356

Merged
andrewhsu merged 1 commit intodocker-archive:19.03from
thaJeztah:19.03_backport_fix_windows_errortype
Sep 24, 2019
Merged

[19.03 backport] Windows: fix error-type for starting a running container#356
andrewhsu merged 1 commit intodocker-archive:19.03from
thaJeztah:19.03_backport_fix_windows_errortype

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

backport of moby#39255

Trying to start a container that is already running is not an error condition, so a 304 Not Modified should be returned instead of a 409 Conflict.

relates to moby#39253

- Description for the changelog

* Windows: fix API status code when starting an already running container. Trying to start a container that is already running is not an error condition, so a `304 Not Modified` should be returned instead of a `409 Conflict`.

- A picture of a cute animal (not mandatory but encouraged)

Trying to start a container that is already running is not an
error condition, so a `304 Not Modified` should be returned instead
of a `409 Conflict`.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit c030885)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 19.03.3 milestone Sep 16, 2019
Copy link
Copy Markdown

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 09f8810 into docker-archive:19.03 Sep 24, 2019
@thaJeztah thaJeztah deleted the 19.03_backport_fix_windows_errortype branch September 24, 2019 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants